Hey @rcap107, I moved the test_add_tostr test into tests/test_table_vectorizer.py, set the default to False, fixed the ordering so CleanCategories runs before ToStr, and fixed the docstring text. About the name, add_tostr works technically, but I agree it doesn’t feel very descriptive. Something like convert_objects might be clearer, but happy to go with whatever you prefer. Let me know if this looks right or if you want me to adjust anything else before I update the PR again.

Hi @PilliSiddharth, I think you forgot to push your latest commit.

In the end, I'd like the parameter to be called cast_to_str. Also, the test_add_tostr should be modified slightly:

• Change the name to cast_to_str
• Test that the default behavior of the Cleaner does not change the type, and that setting cast_to_str=True does change the type as expected. In the current version, we're not testing the default behavior.

Hey @rcap107, I pushed the updates: renamed the parameter to cast_to_str, updated the test and docstring, and fixed the example output.

Hi @PilliSiddharth, thanks a lot for the PR. I made a small change in the order of parameters, swapping cast_to_str and n_jobs. Aside from that, it looks good to me and I'll merge it once the CI is done.

An aside, if you are having issues with doctests failing, it's often easier to use the ELLIPSIS (...) to skip parts of the test. In some cases the same test can fail with specific package/python versions because the string representations change from one version to another, and using ... is the simplest way to get the tests to pass.

Whoops, the order change broke the CI, I'll fix it

Sounds good, glad I could be a part! 😄