Skip to content

removes incorrect duplicate parsing of TimeDateStamp #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jhhcs wants to merge 2 commits into
base: main
Choose a base branch
from
Open

removes incorrect duplicate parsing of TimeDateStamp #48

jhhcs wants to merge 2 commits into from

Conversation

@jhhcs
Copy link

@jhhcs jhhcs commented Nov 24, 2025 •
edited
Loading

I ran into an issue where the TimeDateStamp value computed by minidump was incorrect. When inspecting the code, I noticed that both the Reserved and TimeDateStamp field were being read as consecutive 32-bit integers:

minidump/minidump/header.py

Lines 42 to 43 in c60f39d

mh.Reserved = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)
mh.TimeDateStamp = int.from_bytes(buff.read(4), byteorder = 'little', signed = False)

This is incorrect, see also the official Microsoft documentation:

typedef struct _MINIDUMP_HEADER {
  ULONG32 Signature;
  ULONG32 Version;
  ULONG32 NumberOfStreams;
  RVA     StreamDirectoryRva;
  ULONG32 CheckSum;
  union {
    ULONG32 Reserved;
    ULONG32 TimeDateStamp;
  };
  ULONG64 Flags;
} MINIDUMP_HEADER, *PMINIDUMP_HEADER;

The Reserved and TimeDateStamp field are the same value since they are in a union. This PR fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhhcs @huettenhain