Fix logUpdate.clear() #5
Conversation
This commit fixes `render.clear` and resolves sindresorhus#4. Also removed `stream.write('\n');` from `render.done`, because it adds an extra empty line (the output in render already includes `\n`, so the caret is already on the next line).
|
@dthree Thoughts on this? |
|
I tested this out in combination with my PR on |
index.js
Outdated
There was a problem hiding this comment.
Not sure if it matters, but seeing as I often use this in a hot loop and some terminals can be slow, I prefer to keep it to one stdout write, as previously.
There was a problem hiding this comment.
The original line cleared the previous log and printed the new log. The clearing bit was a duplication of what the clear function does, so I thought it might be better to just call it (keeping with the DRY principle).
The other reason to separate it, is that if clear will ever be broken again you will know it immediately since the output will be messed up.
That said, if you think there's a possible performance issue, I'll change it.
|
👍 when my inline comment is resolved. |
This is done to improve performance on slow terminals.
|
Thanks @etiktin :) |
|
You're welcome :) |
This commit fixes
render.clearand resolves #4.Also removed
stream.write('\n');fromrender.done, because it adds an extra empty line (the output in render already includes\n, so the caret is already on the next line).