Add support for relative parent paths #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Node 0.12 and lower are broken but i think we should drop its support (2 LTS versions behind us). Also, i think we should add a major version since it may break some existing code. Otherwise i think we should merge this since it looks like a lot of people could benefit from it. We still have the choice to make this behavior optional and only bump a minor version. |
sindresorhus
requested changes
Jan 7, 2017
index.js
Outdated
| match = pattern(file); | ||
| } else { | ||
| var relPath = path.relative(file.cwd, file.path); | ||
| if (relPath.indexOf('..') === 0) { |
There was a problem hiding this comment.
And needs a short code comment about why it's there.
|
I'll drop Node.js 0.12 support after this PR is merged. Just ignore the failure for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, paths can now reference files outside the current working directory. So now, the pattern
**/*.jswill match../../some/file.jsThe only caveat is your pattern has to start with
**to match the resolved absolute paths of relative parent paths. In other words, you must do**/test/**/*.jsin order to match../../test/file.jsand not match../../src/code.js. This is a limitation of minimatch, not gulp-filter, gulp, or this PR.Fixes #74.