Allow passing of can_stream in openai_models.py #600
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes simonw#599 A longer term fix would be to use something like Pydantic so we don't repeat ourselves, but this would be a bit of a refactor
Owner
|
This fix doesn't look quite right to me. The code currently defaults to assuming llm/llm/default_plugins/openai_models.py Lines 283 to 293 in 1a60fa1 With this change that will switch to assuming I think this should only take effect if |
fast-codi-expert
added a commit
to fast-codi-expert/LLM
that referenced
this pull request
May 18, 2025
* Allow passing of can_stream in openai_models.py Fixes #599 * Only set can_stream: false if it is false Refs simonw/llm#600 (comment) * Docs for can_stream: false --------- Co-authored-by: Simon Willison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599
A longer term fix would be to use something like Pydantic so we don't repeat ourselves, but this would be a bit of a refactor