Skip to content

Conversation

@Lomanic
Copy link
Collaborator

@Lomanic Lomanic commented Mar 6, 2025

Tested with CGO_ENABLED=0 GOOS=aix GOARCH=ppc64 go test ./... | grep -v "exec format error" | grep "build failed"

Amends #1797
Fixes #1806

@Lomanic Lomanic changed the title [net][host][aix] Fix build and and Makefile [net][host][aix] Fix build and Makefile Mar 6, 2025
Copy link
Owner

@shirou shirou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirou shirou merged commit e2a7a99 into shirou:master Mar 6, 2025
48 checks passed
@Dylan-M
Copy link

Dylan-M commented Mar 12, 2025

I'm late to the party, but this actually introduced a bug. The redundant or that was removed, actually wasn't. It was just a different bug, The one that was removed shouldn't have had the comma.

@shirou
Copy link
Owner

shirou commented Mar 15, 2025

@Dylan-M ah, so you mean the case should be like this? If so, I will open a another PR.

case ut[3] == "mins," || ut[3] == "mins"

@Dylan-M
Copy link

Dylan-M commented Mar 19, 2025

@Dylan-M ah, so you mean the case should be like this? If so, I will open a another PR.

case ut[3] == "mins," || ut[3] == "mins"

That is correct. Sorry for the delayed reply. It has been very busy at work, or I would have just submitted my own quick PR for this. Instead I'm deep into the bowels of AIX working on adding Process metrics support for this library ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AIX build fails to run with CGO_ENABLED=0

3 participants