fix: deprecation warning on Windows #240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawn-command-with-kill uses an outdated version of spawn-command which causes a deprecation warning to be printed when running scripts due to the latter's use of util._extend.
Author
|
@sezna Did you get a chance to look at this? We run on many Windows machines and there's a glaring red warning every time a script is run, would be nice to have this fixed. I realize this package hasn't been updated in some years, but maybe this PR and #231 can be included in a patch release. I haven't encountered any other visible issues thus far. |
Owner
|
It looks like the actions are hanging. I'll take a look at that and then get this PR in. |
Author
|
@sezna Were you able to figure out the issue? I see the project is still using Travis CI, I'm not sure if that still works, but it might be easier to switch to GitHub Actions. |
Author
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spawn-command-with-kill uses an outdated version of spawn-command which causes a deprecation warning to be printed when running scripts due to the latter's use of util._extend.
What:
Why:
How:
Checklist: