Add "Include Default Extension" Option (Resolve #1924, Resolve #1933) #2366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's been a long standing bug (reported in #1924 and #1933) where custom filenames which contained periods (
.) in the template or any token's replacement value would fail to include the default file extension. Although this has already been addressed somewhat by 319eee3, I feel adding the ability to configure whether the extension is included would:I used the
export-refactoringbranch as a base because it includes modification to files also changed in the PR. If you decide to scrap those changes, let me know, and I'll make a new PR using themasterbranch as a base.I currently have Xcode Version 7.2 (7C68) and MacOS X 10.11.2 installed therefore any changes made to
ExportDialog.xibrequired an update to file schema. To help make the merge process easier for you, I've divided this PR into 3 commits. I first updated the schema without making any changes then separately committed the interface and code changes. This should allow you to either: