Skip to content

Conversation

@ccojocar
Copy link
Member

No description provided.

@ccojocar ccojocar requested a review from gcmurphy July 19, 2018 16:46
@ccojocar ccojocar merged commit f254cec into securego:master Jul 19, 2018
vprithvi added a commit to jaegertracing/jaeger that referenced this pull request Jul 19, 2018
GoASTScanner/gas was renamed to gosec in securego/gosec#216 causing our
builds to break. This commit renames gas to gosec to fix builds.

Resolves #945
Signed-off-by: Prithvi Raj <[email protected]>
@vprithvi
Copy link

This rename breaks builds installing gas using go get, consider keeping the gas cmd (or perhaps aliasing it) so that users have time to migrate?

yurishkuro pushed a commit to jaegertracing/jaeger that referenced this pull request Jul 19, 2018
GoASTScanner/gas was renamed to gosec in securego/gosec#216 causing our
builds to break. This commit renames gas to gosec to fix builds.

Resolves #945
Signed-off-by: Prithvi Raj <[email protected]>
liontwinkle added a commit to liontwinkle/go-jeager that referenced this pull request Aug 1, 2020
GoASTScanner/gas was renamed to gosec in securego/gosec#216 causing our
builds to break. This commit renames gas to gosec to fix builds.

Resolves #945
Signed-off-by: Prithvi Raj <[email protected]>
outdoorSpirit pushed a commit to outdoorSpirit/Go-Jag that referenced this pull request May 3, 2024
GoASTScanner/gas was renamed to gosec in securego/gosec#216 causing our
builds to break. This commit renames gas to gosec to fix builds.

Resolves #945
Signed-off-by: Prithvi Raj <[email protected]>
@ccojocar ccojocar deleted the rename_gas_with_gosec branch May 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants