fix: G602 support for nested conditionals with bounds check #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
+ Coverage 67.35% 67.84% +0.49%
==========================================
Files 74 75 +1
Lines 4046 4186 +140
==========================================
+ Hits 2725 2840 +115
- Misses 1195 1210 +15
- Partials 126 136 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ccojocar
requested changes
Sep 1, 2024
Member
ccojocar
left a comment
There was a problem hiding this comment.
Thanks for contributing this fix. I left a few comments, it would be great if you could address them. Thanks again!
ccojocar
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #1200 with this PR.
Suggestions/comments more than welcome