fix: artifacts are downloaded to wrong directory for conda release wf #3459
Conversation
Currently they are downloaded to `$GITHUB_WORKSPACE`, but the conda publish command expects them to be in `$GITHUB_WORKSPACE/conda-package-*/etc` where `conda-package-*` are the artifact names...
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| merge-multiple: true |
There was a problem hiding this comment.
Can you also update the anaconda command to
anaconda --token ${{ secrets.ANACONDATOKEN }} upload --user scipp --label main $(find . -type f -name "*.tar.bz2")
This should get all the files out with the extension we are looking for.
Or we can come up with the right path looking at
scipp/.github/workflows/conda.yml
Line 53 in 9603035
There was a problem hiding this comment.
This would probably also work, but I think it is also fine as it is now?
Without merge-multiple the artifacts will be downloaded in separate directories that are named with the same name as the artifact name. The docs were a bit fuzzy on this point, but looking at the code it seems that's what's happening, see here.
In our case the artifacts are named like conda-package-linux_64-py3.10 so the directory structure after download will be:
$GITHUB_WORKSPACE/conda-package-linux_64-py3.10/linux64/scipp-24.05.0-py310hf5249f7_0.tar.bz2
$GITHUB_WORKSPACE/conda-package-osx_64-py3.10 /osx_64/scipp-24.05.0-py310kj5b34fj87_0.tar.bz2
...etc
and then the $(ls conda-package-*/*/*.tar.bz2) should do the right thing.
I'm hesitant to make more changes than necessary 😅 that's why I'm a bit reluctant to add this. But if you think it will not work like it is, or if you think it would be better to change it for some other reason, I'll do that.
Currently they are downloaded to
$GITHUB_WORKSPACE, but the conda publish command expects them to be in$GITHUB_WORKSPACE/conda-package-*/etcwhereconda-package-*are the artifact names...Removing the
merge-multipleoption (docs) makes the artifacts "be extracted into individual named directories", I assume (hope) the directory names will be the same as the artifact names, because that is what we want.