DEP: Remove numerical arguments from convolve2d / correlate2d #8542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
+1 for removal from me. We can re-add properly later if people end up needing them. |
ilayn
reviewed
Mar 13, 2018
scipy/signal/signaltools.py
Outdated
| val = boundary << 2 | ||
| return val | ||
| raise ValueError("Acceptable boundary flags are 'fill', 'wrap'" | ||
| " (or 'circular'), \n and 'symm'" |
Member
There was a problem hiding this comment.
I think a manual line break is not needed here since most consoles are softwrapping messages anyways. A small nitpick I would suggest the following; first giving the actual full mode name and then the alias.
raise ValueError("Unknown flag type given. Valid options are 'fill', 'wrap'"
" 'circular' (or 'circ' ), and 'symmetric' (or 'symm' ).")
Member
Author
There was a problem hiding this comment.
Ok I changed it similarly
dabd29e to
907c34b
Compare
Member
|
New commit is only a change in the commit test so merging. Thanks @endolith ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #8413 (comment), it has never actually been possible to set the boundary using an integer, since
_bvalfromboundaryhas been broken since it was created 17 years ago, raisingUnboundLocalError: local variable 'val' referenced before assignment.The mode argument
_valfrommodewas initially broken the same way, but fixed shortly afterward .But if no one noticed that it doesn't work for
boundary=in the last 17 years, it seems like numeric parameters are not commonly used. Also they are untested, and were removed from the documentation 8 years ago.Is there any benefit to supporting them?