This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Migration to webpack 2 #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only missing feature is the style loader
Enable source maps and trigger minififacion on loaders
xaviervia
reviewed
Apr 7, 2017
| - `font` | ||
| - `image` | ||
| - `javaScript` | ||
| - `json` |
Member
Author
There was a problem hiding this comment.
It is no longer needed in webpack 2. They do it by default.
| // To ensure hashes are generated based on the file contents, use webpack-md5-hash plugin. | ||
| ...(action === actions.BUILD ? [new WebpackMd5Hash()] : []), | ||
|
|
||
| // Use "OccurrenceOrderPlugin" in order to make build deterministic. |
Member
There was a problem hiding this comment.
I’m assuming this are Webpack defaults now.
| // Should first try to resolve loaders nested within Sagui. | ||
| // This fixes an issue in NPM v2 where webpack incorrectly | ||
| // thinks that the package `eslint` is the `eslint-loader` | ||
| modulesDirectories: [ |
Member
There was a problem hiding this comment.
The comments points out to an npm 2 problem, but I imagine npm 2 is super deprecated at this point. Is this in general necessary?
Member
Author
There was a problem hiding this comment.
Good point, maybe we can update it. I think it is still a safe bet to be explicit about where to look for loaders.
Member
There was a problem hiding this comment.
Fair enough, just updating the comment for now should do.
| use: [ | ||
| { | ||
| loader: 'file-loader', | ||
| options: { |
xaviervia
approved these changes
Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.