[cxx-interop] [test] Refactor nonescapable test to use -verify #86106
Conversation
|
@swift-ci please smoke test |
|
@susmonteiro @Xazax-hun It might also be a good idea to split up this test. It's quite difficult to read, and a bit slow to run because of the dependency on But I'll leave it up to y'all since you were the ones who actually wrote this test (-: I just need this patch because my ongoing work elsewhere (#86048) apparently changes one of the error messages and I am having a really hard time telling whether the new diagnostic behavior should be expected. |
Xazax-hun
left a comment
There was a problem hiding this comment.
Thanks a lot! This was long overdue and I wanted to get to it but always got distracted with something else. This is a huge improvement!
I have mixed feelings about splitting it up though. The more slightly related test files we have the harder to find the test case we are looking for or to figure out where to put new tests.
|
ah yes, I forgot about Windows.... I just need |
Checking errors with FileCheck is fragile (because of line numbers) and difficult to follow.
bb18f81 to
9ae5348
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows platform |
Checking errors with FileCheck is fragile (because of line numbers) and difficult to follow.