[ConstraintSystem] TVO_PrefersSubtypeBinding: Stop checking when found solution(s) with a subtype binding #86096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` early Update `matchFunctionRepresentations` to reject convesions from Swift to `convention(c)` function types for everything but closures and declaration references. Closures and declaration references are allowed because their eligibility depends on captures which might not be ready during solving.
…d solution(s) with a subtype binding For `TVO_PrefersSubtypeBinding` type variables bindings are sorted to make sure that non-subtype/equal bindings are attempted last, so if any subtype or equality bindings produced a solution, checking could be stopped since supertype bindings are always considered to be worse. Resolves: rdar://125948508 Resolves: rdar://136315240
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please test Linux platform |
Contributor
Author
|
swiftlang/llvm-project#12020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
TVO_PrefersSubtypeBindingtype variables bindings aresorted to make sure that non-subtype/equal bindings are attempted
last, so if any subtype or equality bindings produced a solution,
checking could be stopped since supertype bindings are always
considered to be worse.
This helps with cases like
@Sendable () -> Void <: $T <: () -> VoidorKeyPath<...> & Sendable <: $T <: KeyPath<...>among others.Resolves: rdar://125948508
Resolves: rdar://136315240