Skip to content

chore: fix test url #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2025
Merged

chore: fix test url #14411

merged 5 commits into from
Sep 12, 2025
+10 −4

Conversation

teemingc
Copy link
Member

This PR fixes the URL the test is suppose to navigate to. I accidentally changed it in https://github.com/sveltejs/kit/pull/13911/files#diff-35da857c87de7945a1a14898efa59865955ced32f6ede60e298a3386be524dd6R1525 . The difference between the two URLs is that one has a non-enhanced form and the second one has an enhanced form. The test should navigate to the page with the non-enhanced form.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63935a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann
Copy link
Member

I wonder if we should name these form-enhanced and form-unenhanced or something instead of form and form2

@teemingc
Copy link
Member Author

I wonder if we should name these form-enhanced and form-unenhanced or something instead of form and form2

Good idea. I can see the test is failing now too 🤦🏼 I'll have a look

@teemingc
Copy link
Member Author

teemingc commented Sep 12, 2025 •
edited
Loading

Ok I've fixed up the tests a bit. Two issues:

To fix these two issues I've made sure both tests have the link and they both click it. I've also renamed them with a suffix "non-enhanced" and "enhanced".

dummdidumm
dummdidumm approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@dummdidumm dummdidumm merged commit fa74736 into main Sep 12, 2025
22 checks passed
@dummdidumm dummdidumm deleted the chore-fix-test-url branch September 12, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teemingc @benmccann @dummdidumm