feat(pipeline): add support for pausing replication #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is pausing replication needed for compaction or other maintenance tasks? Can't these other tasks run in parallel in the background? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a signal for pausing the replication stream. In my delta branch, I often need to pause replication to perform compactation/z-ordering to prevent the table from having too many files. I wanted to pause the whole replication process instead of taking a long time to await a future.
What is the current behavior?
No easy way to pause a pipeline.
What is the new behavior?
Adds a signal to pause.
Additional context
This is marked as draft because a test isn't passing, and I'm trying to figure out why. I'm also not convinced this is the correct API design.