receive *testing.T via an interface #32
Merged
+37
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'm currently using the |
|
Durp... I'm an idiot. This should be better: no need to import any other packages. |
matryer
pushed a commit
that referenced
this pull request
Jan 28, 2014
receive *testing.T via an interface
|
... what if we just call that interface |
|
doesn't much matter to me :) |
|
FWIW, the Ginkgo side of things is now done and there's documentation on how to get testify working with Ginkgo: http://onsi.github.io/ginkgo/#using_other_matcher_libraries (or it will be there as soon as github-pages finishes regenerating the page) |
|
@onsi - great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is related to:
#27
Receiving testing.T via an interface would allow Ginkgo to provide an implementation of the interface that works with Ginkgo's test runner.
I defined an interface in a new package called
interfaces... if you don't like that there are other options (e.g. have an interface for this defined in each package)? I'd be happy to iterate on this.If this gets pulled in I'll add an adapter to Ginkgo (and some examples) to make using testify's assertion and mock libraries trivial.