Skip to content

assert.ErrorAs: simplify retrieving the type name #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

assert.ErrorAs: simplify retrieving the type name #1740

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions assert/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,17 +2225,17 @@ func ErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interface{
return true
}

expectedText := reflect.ValueOf(target).Elem().Type().String()
expectedType := reflect.TypeOf(target).Elem().String()
if err == nil {
return Fail(t, fmt.Sprintf("An error is expected but got nil.\n"+
"expected: %s", expectedText), msgAndArgs...)
"expected: %s", expectedType), msgAndArgs...)
}

chain := buildErrorChainString(err, true)

return Fail(t, fmt.Sprintf("Should be in error chain:\n"+
"expected: %s\n"+
"in chain: %s", expectedText, chain,
"in chain: %s", expectedType, chain,
), msgAndArgs...)
}

Expand All @@ -2253,7 +2253,7 @@ func NotErrorAs(t TestingT, err error, target interface{}, msgAndArgs ...interfa

return Fail(t, fmt.Sprintf("Target error should not be in err chain:\n"+
"found: %s\n"+
"in chain: %s", reflect.ValueOf(target).Elem().Type(), chain,
"in chain: %s", reflect.TypeOf(target).Elem().String(), chain,
), msgAndArgs...)
}

Expand Down