Skip to content

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2024
Merged

README: replace Testify V2 notice with @dolmen's V2 manifesto #1518

merged 2 commits into from
Oct 26, 2024

Conversation

hendrywiranto
Copy link
Contributor

Summary

Remove Testify V2 notice on README.md since it won't happen

Changes

  • Remove Testify V2 notice on README.md

Motivation

According to this announcement #1089 (comment) from @dolmen

So, as the current only active maintainer, I'm declaring that v2 will never happen. Or at least a v2 of the github.com/stretchr/testify module with such major breaking changes.

Related issues

Issues that can be closed:
#1089

@Antonboom
Copy link

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

@hendrywiranto
Copy link
Contributor Author

hi!

maybe it's better not to remove, but (in contradict) notice about v2 manifesto?

Yes, I think that's also a good idea. I'm thinking if maintainers want to link the manifesto instead I will just change the MR

Lets wait his response maybe?

@dolmen
Copy link
Collaborator

dolmen commented Jan 5, 2024 •
edited
Loading

Yes, linking to my manifesto would be better.
In a normal world I would have made the change in the README myself, but as I am not allowed to merge my own PRs, I'm relying on other contributors to submit such patches. 😓

@hendrywiranto hendrywiranto force-pushed the adjust-readme-remove-v2 branch from f428650 to b48f25e Compare January 6, 2024 17:12
@hendrywiranto
Copy link
Contributor Author

Thanks for the answer, I have updated the readme with the manifesto
Please tell me if you think there is a better wording for this

@hendrywiranto hendrywiranto changed the title Remove Testify V2 notice on readme since it won't happen Replace Testify V2 notice with maintainer's V2 manifesto on readme Jan 9, 2024
@Antonboom
Copy link

@hendrywiranto also grep "testify v2"
e.g. https://github.com/stretchr/testify/blob/master/doc.go

@hendrywiranto hendrywiranto force-pushed the adjust-readme-remove-v2 branch from dac4a1b to d370c30 Compare January 10, 2024 16:03
@hendrywiranto
Copy link
Contributor Author

thanks for the reminder @Antonboom

@MovieStoreGuy
Copy link
Collaborator

Hi,

I am relatively new comer to the maintainers group for this, I mostly come from the opentelemetry collector contrib where I use this heavily, and also internally here at Altassian.

As slow as it has been for V2 (apologies for those asking for it), I think it should be the ambition of 2024 to see v2 released.

Let me follow up with @boyan-soubachov on this and we can start getting together a more formal roadmap / milestone for V2 if it doesn't already exist.

@hendrywiranto
Copy link
Contributor Author

Hi @MovieStoreGuy

I'm glad to hear that there is still plan for V2!
Hope you guys can figure something out while making sure this repo (V1) is still maintained regularly

Thanks!

@hendrywiranto hendrywiranto force-pushed the adjust-readme-remove-v2 branch from d370c30 to 3b4b536 Compare February 21, 2024 15:38
brackendawson
brackendawson requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@brackendawson brackendawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a concensus about this between the maintainers right now. I'm not requesting any changes, just temporarily putting a hold on this.

@dolmen
Copy link
Collaborator

dolmen commented Mar 5, 2024

I have proposed a different wording to expose the active debate about v2.

@dolmen dolmen changed the title Replace Testify V2 notice with maintainer's V2 manifesto on readme README: replace Testify V2 notice with maintainer's V2 manifesto Mar 7, 2024
@dolmen dolmen changed the title README: replace Testify V2 notice with maintainer's V2 manifesto README: replace Testify V2 notice with @dolmen's V2 manifesto Mar 7, 2024
@dolmen dolmen mentioned this pull request May 16, 2024
Open
brackendawson
brackendawson requested changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@brackendawson brackendawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I at least have changed my mind about testtify v2, that may mean there is now a concensus among the maintainers that it is a no.

README.md Outdated
Comment on lines 4 to 5
Notice about Testify V2:
It won't happen due to various reasons. You can read more about it on the maintainer's manifesto [here](https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Notice about Testify V2:
It won't happen due to various reasons. You can read more about it on the maintainer's manifesto [here](https://github.com/stretchr/testify/issues/1089#issuecomment-1812734472).
> [!NOTE]
> Testify is being maintained at v1, no breaking changes will be accepted in this repo. [See discussion about v2](https://github.com/stretchr/testify/discussions/1560).

Suggest using a proper GitHub markdown note and remove the emotional language from the note.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brackendawson
Thank you for finally coming to a concensus, I have applied your suggestion. 😄

@brackendawson brackendawson mentioned this pull request Sep 29, 2024
Closed
@hendrywiranto hendrywiranto force-pushed the adjust-readme-remove-v2 branch from 50edd68 to 2780579 Compare October 26, 2024 16:19
@brackendawson brackendawson merged commit