Skip to content

Fixed assert.EqualError to call Equal with args in the right order. #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Fixed assert.EqualError to call Equal with args in the right order. #126

wants to merge 0 commits into from

Conversation

willfaught
Copy link
Contributor

This fixes confusing error reports like this:

--- FAIL: TestDefaultError (0.00s)
        Location:       error_test.go:47
        Error:          Not equal: "b" (expected)
                                != "a" (actual)
        Messages:       An error with value "a" is expected but got "b".

Note that the Error line says "b" is expected, but the Messages line says "a" is expected.

@andybons andybons mentioned this pull request Feb 17, 2015
Closed
@willfaught willfaught closed this Feb 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@willfaught