indent actual value for better comparison with expected value #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This repo has been forked. Please feel free to open a new PR here: https://github.com/test-go/testify |
|
@philtay, I guess your fork will be updated when this Pr gets merged. |
|
@Oppodelldog nothing wrong. The fact is that this repo is not maintained anymore. Most probably your PR will never be merged here. You created it 5 months ago... |
ernesto-jimenez
approved these changes
Dec 30, 2017
|
@Oppodelldog thanks, merging @philtay, it's not abandoned, it just takes quite a bit of time to review things properly and I've been quite busy with the new job. More than happy to get help triaging and reviewing issues and PRs :) |
|
@ernesto-jimenez c'mon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an indentation of the actual value quite useful for comparison.
My usecase for this change was the equal assertion on two urls with parameters where a parameter was missing in one of both urls.
An indentation helped a lot in this case.