Skip to content

Conversation

aytey
Copy link
Member

@aytey aytey commented Oct 26, 2020

When I implemented scopes, there was a bug where the copy constructor would get called twice when creating and then adding a scope to the vector of all scopes.

This "double creation" meant that functions were cleaned-up at the wrong time.

This PR changes it such that frames are only created once. An option here would have been to define a move constructor and use emplace_back (rather than frames being a vector of pointers) -- @msoos do you have a preference here?

Signed-off-by: Andrew V. Jones [email protected]

@msoos
Copy link
Member

msoos commented Oct 26, 2020

👍 Looking great!

@aytey aytey merged commit 65b8bd3 into stp:master Oct 27, 2020
@aytey aytey deleted the fix_scopes branch October 27, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants