Ensuring that we do not create double frames when creating a new frame (closes #385) #387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented scopes, there was a bug where the copy constructor would get called twice when creating and then adding a scope to the vector of all scopes.
This "double creation" meant that functions were cleaned-up at the wrong time.
This PR changes it such that frames are only created once. An option here would have been to define a move constructor and use
emplace_back
(rather than frames being a vector of pointers) -- @msoos do you have a preference here?Signed-off-by: Andrew V. Jones [email protected]