drpcwire: expose buffer size on Reader #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #29. |
|
Unfortunately, changing NewReader to take a new parameter is an API breaking change. Instead, can we add a new NewReaderOptions function that takes a ReaderOptions struct type and change NewReader to call that? |
|
Yup! I had that initially but wanted to stay consistent with |
The maximum was hardcoded at 4MB. This allows it to be configurable for larger payloads. An option is exposed in `dprcmanager.Options`.
550b607 to
d6d4c88
Compare
|
@zeebo it's been updated! |
zeebo
approved these changes
Apr 24, 2022
egonelbre
approved these changes
Apr 25, 2022
kylecarbs
added a commit
to kylecarbs/drpc
that referenced
this pull request
Jun 21, 2022
* drpcwire: expose buffer size on Reader (storj#30) The maximum was hardcoded at 4MB. This allows it to be configurable for larger payloads. An option is exposed in `dprcmanager.Options`. * regen docs Change-Id: I04ac7c0c5bea05a95ee38cd0584ca624ce60f077 * Don't reuse buffer after Write() Signed-off-by: Spike Curtis <[email protected]> Co-authored-by: Kyle Carberry <[email protected]> Co-authored-by: Jeff Wendling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum was hardcoded at 4MB. This allows it to
be configurable for larger payloads. An option is
exposed in
dprcmanager.Options.