Allow for filtering on what Timer metrics are sent out by statsd #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_metric_set 1901/tech 3080 reduce statsd implied metric set
sbonebrake
reviewed
Mar 27, 2019
| If disabled, it is up to the backends to sanitize keynames | ||
| as appropriate per their storage requirements. | ||
| calculated_timer_metrics: List of timer metrics that will be sent. Default will send all metrics. |
There was a problem hiding this comment.
Doesn't follow casing style. Should be calculatedTimerMetrics
Contributor
Author
|
Switched branches to merge a non-master branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are over a dozen metrics that get sent out for every timer stat that comes in. Being able to filter on the specific aggregated metrics you want for a timer at the config level will allow for drastic reduction in the data sent out from statsd and stored.
The config that I've added is
calculated_timer_metricswhich by default will send all metrics, however once any other value(s) are added, it will only send those specified. This also allows for the not sending percentile metrics as well.Currently running these changes in production has reduced our Carbon/whisper load by ~20%.
Related to this issue:
#235