pass program counter to CallerMarshalFunc #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
reviewed
Jul 29, 2022
Contributor
Author
|
thanks for merging @rs! Would you mind also creating a new git tag, so I can update our deps? |
Contributor
Author
|
@rs could you create a v1.28.0 tag? |
Owner
|
done |
rs
pushed a commit
that referenced
this pull request
Sep 9, 2022
There was changes in #457 pass program counter to CallerMarshalFunc. Update example in README.md
pablitoc
pushed a commit
to nxcr-org/zerolog
that referenced
this pull request
Apr 7, 2023
pablitoc
pushed a commit
to nxcr-org/zerolog
that referenced
this pull request
Apr 7, 2023
There was changes in rs#457 pass program counter to CallerMarshalFunc. Update example in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes the pc var to marshallers to be able to add function names to caller fields.
This is a breaking change for those that have overridden
CallerMarshalFuncbefore, as the func signature changes.All tests passed locally.
Resolves #456