This repository was archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): properly retain parentheses in body #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
ematipico
approved these changes
Jul 20, 2023
Contributor
ematipico
left a comment
There was a problem hiding this comment.
Weird that there isn't any test that regressed. Happy to merge!
Contributor
|
Could we add a test case? 🤞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
arrow_parenthesesoption currently removes parentheses to the body that would otherwise be added to avoid confusion. Since this is probably not expected to anyone using the option (considering prettier doesn't remove them), this PR reverts this behaviorTest Plan
cargo t