Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): skip this reference identifier in the semantic analyzer #4675

Merged
ematipico merged 3 commits into from
Jul 10, 2023
Merged

fix(rome_js_analyze): skip this reference identifier in the semantic analyzer #4675

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d98dc5
fix: skip `this` reference representing the class instance
nissy-dev Jul 9, 2023
b144b4a
fix: remove debug codes
nissy-dev Jul 10, 2023
63056ed
docs: update changelog
nissy-dev Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove debug codes
  • Loading branch information
@nissy-dev
nissy-dev committed Jul 10, 2023
commit b144b4a35e5173ca81b2dd0385a2d2e0891afd3a
2 changes: 0 additions & 2 deletions crates/rome_js_analyze/src/semantic_analyzers/correctness/no_undeclared_variables.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,7 @@ impl Rule for NoUndeclaredVariables {
ctx.query()
.all_unresolved_references()
.filter_map(|reference| {
// dbg!(&reference);
let identifier = reference.tree();
dbg!(&identifier);
let under_as_expression = identifier
.parent::<TsReferenceType>()
.and_then(|ty| ty.parent::<TsAsExpression>())
Expand Down