Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noFallthroughSwitchClause #4626

Merged
ematipico merged 6 commits into from
Jul 7, 2023
Merged

feat(rome_js_analyze): noFallthroughSwitchClause #4626

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0107a8b
feat(rome_js_analyze): noFallthroughSwitchClause
ddanielsantos Jun 28, 2023
d6c10a2
fix(rome_js_analyze): take continue statement into consideration
ddanielsantos Jun 29, 2023
a2fb93b
fix(rome_js_analyze): use count instead of peekable
ddanielsantos Jun 29, 2023
c7db366
docs(rome_js_analyze): fix typos
ddanielsantos Jun 29, 2023
91950cf
fix(rome_js_analyze): remove into_iter
ddanielsantos Jul 7, 2023
b67ad0f
chore: ready
ddanielsantos Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(rome_js_analyze): fix typos
  • Loading branch information
@ddanielsantos
ddanielsantos committed Jul 7, 2023
commit c7db366f3f4695d7b8e3443ac341fb37a4f2d9de
6 changes: 3 additions & 3 deletions crates/rome_js_analyze/src/analyzers/nursery/no_fallthrough_switch_clause.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ use rome_js_syntax::{
};

declare_rule! {
/// Disallow fallthrough of case statements
/// Disallow fallthrough of case statements.
///
/// Case statements in switch statements fall through by default. This can lead to unexpected behavior when forgotten.
/// This rule disallows fallthrough of case statements.
/// This rule disallows the fallthrough of case statements.
///
/// Source: https://eslint.org/docs/latest/rules/no-fallthrough
///
Expand Down Expand Up @@ -82,7 +82,7 @@ impl Rule for NoFallthroughSwitchClause {
},
)
.note(markup! {
"Add a `break` statement to the end of this case to prevent fallthrough."
"Add a `break` or `return` statement to the end of this case to prevent fallthrough."
}),
)
}
Expand Down