Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_parser): TS 5.0 export type * #4228

Merged
ematipico merged 1 commit into from
Feb 25, 2023
Merged

feat(rome_js_parser): TS 5.0 export type * #4228

ematipico merged 1 commit into from
Feb 25, 2023

Conversation

@Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Feb 22, 2023 •
edited
Loading

Summary

Part of #4227.
This adds the support for export type *.

Test Plan

Tests included.

Documentation

#2400 and #4227 have to be implemented before updating the TypeScript supported version on the website.

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b380c81
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63f944d92ced3b0008736565
😎 Deploy Preview https://deploy-preview-4228--docs-rometools.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Conaclos Conaclos mentioned this pull request Feb 22, 2023
Closed
2 tasks
@ematipico
Copy link
Contributor

ematipico commented Feb 23, 2023

@Conaclos actually, this PR requires some change in the documentation: https://docs.rome.tools/internals/language_support/#typescript-support

But I suppose we can change it once #4227 is closed.

ematipico
ematipico suggested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add some tests in our formatter test suite

@Conaclos
Copy link
Contributor Author

Conaclos commented Feb 24, 2023

I think we should add some tests in our formatter test suite

Added :)

I made some minor refactoring to improve the code.

@Conaclos
Copy link
Contributor Author

Conaclos commented Feb 24, 2023

@Conaclos actually, this PR requires some change in the documentation: https://docs.rome.tools/internals/language_support/#typescript-support

But I suppose we can change it once #4227 is closed.

This is a good point!
#2400 has also to be resolved.

@Conaclos Conaclos requested a review from ematipico February 24, 2023 23:50
@ematipico ematipico merged commit e6052d0 into rome:main Feb 25, 2023
@Conaclos Conaclos deleted the rome_js_parser/export_type branch March 7, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ematipico ematipico ematipico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Conaclos @ematipico