This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noDuplicatePrivateClassMembers
#4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
ematipico
reviewed
Jan 9, 2023
crates/rome_js_analyze/src/syntax/nursery/no_duplicate_private_class_members.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/syntax/nursery/no_duplicate_private_class_members.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/syntax/nursery/no_duplicate_private_class_members.rs
Show resolved
Hide resolved
|
This PR is stale because it has been open 14 days with no activity. |
ematipico
approved these changes
Feb 14, 2023
Contributor
ematipico
left a comment
There was a problem hiding this comment.
We should rebase and then we can merge it!
Contributor
Author
|
I merged the latest main branch and this PR is ready to merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #4143
Test Plan
I added snapshot tests
Documentation