This repository was archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 649
feat(rome_js_analyze): noExtraLabels
#4126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
leops
reviewed
Jan 2, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_extra_labels.rs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
There is an issue with the PR workflow... |
Contributor
You have to run the command lintdoc again |
Contributor
Author
In fact the issue comes from out-dated base. This is due to #4099. |
|
This PR is stale because it has been open 14 days with no activity. |
ematipico
approved these changes
Feb 3, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_extra_labels.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_extra_labels.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4125
Test Plan
ESLint's unit tests included.
Documentation