Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Conversation

@Conaclos
Copy link
Contributor

@Conaclos Conaclos commented Dec 31, 2022

Summary

Closes #4125

Test Plan

ESLint's unit tests included.

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@Conaclos Conaclos requested review from a team, ematipico, leops and xunilrj as code owners December 31, 2022 19:30
@netlify
Copy link

netlify bot commented Dec 31, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 51ea75e
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63de6efbebb10c00099d741a
😎 Deploy Preview https://deploy-preview-4126--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Conaclos Conaclos requested review from leops and removed request for ematipico and xunilrj January 2, 2023 18:15
@Conaclos
Copy link
Contributor Author

Conaclos commented Jan 2, 2023

There is an issue with the PR workflow...

@ematipico
Copy link
Contributor

There is an issue with the PR workflow...

You have to run the command lintdoc again

@Conaclos
Copy link
Contributor Author

Conaclos commented Jan 3, 2023

You have to run the command lintdoc again

In fact the issue comes from out-dated base. This is due to #4099.

@github-actions
Copy link

This PR is stale because it has been open 14 days with no activity.

@github-actions github-actions bot removed the S-Stale label Feb 3, 2023
@Conaclos Conaclos requested review from ematipico and removed request for leops February 3, 2023 17:10
@ematipico ematipico merged commit 2ee3742 into rome:main Feb 4, 2023
@Conaclos Conaclos deleted the no_extra_labels branch March 7, 2023 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

noExtraLabels, no-extra-labels

3 participants