Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): noPrototypeBuiltins #4101

Merged
ematipico merged 6 commits into from
Jan 9, 2023
Merged

feat(rome_js_analyze): noPrototypeBuiltins #4101

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3bb10b7
feat(rome_js_analyze): noPrototypeBuiltins
unvalley Dec 23, 2022
1c52728
refactor: get callee by function and use hyperlink
unvalley Dec 30, 2022
18b7e35
refactor: use omit_parentheses and fix is_prototype_builtins
unvalley Dec 30, 2022
591200c
docs: update noPrototypeBuiltins.md
unvalley Dec 30, 2022
50c6577
chore: remove waste import
unvalley Dec 30, 2022
120d959
chore: just codegen
unvalley Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: get callee by function and use hyperlink
  • Loading branch information
@unvalley
unvalley committed Jan 9, 2023
commit 1c52728fc71325e6377af9371960eab2b75157df
5 changes: 2 additions & 3 deletions crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ impl Rule for NoPrototypeBuiltins {

fn run(ctx: &RuleContext<Self>) -> Self::Signals {
let call_expr = ctx.query();
let JsCallExpressionFields { callee, .. } = call_expr.as_fields();
let mut callee = callee.ok()?;
let mut callee = call_expr.callee().ok()?;

// We need to handle a parenthesized expression case e.g. `(foo?.hasOwnProperty)("bar");`
if let AnyJsExpression::JsParenthesizedExpression(expr) = callee {
Expand Down Expand Up @@ -132,7 +131,7 @@ impl Rule for NoPrototypeBuiltins {
"It's recommended using "<Emphasis>"Object.hasOwn()"</Emphasis>" instead of using "<Emphasis>"Object.hasOwnProperty()"</Emphasis>"."
})
.note(markup! {
"See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn"
"See "<Hyperlink href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwn">"MDN web docs"</Hyperlink>" for more details."
}),
)
} else {
Expand Down