This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_json_formatter): Fallback to Verbatim for nodes with syntax errors #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
… errors Some prettier tests for JSON5 are failing after implementing array formatting in #4064 The tests fail because the formatting returns a `FormatError::SyntaxError` if a mandatory child node is missing but the error is never handled by the JSON formatting. This PR fixes this by * Gracefully handle missing values on the root value by calling into verbatim formatting if that's the case * Use `format_or_verbatim` when formatting values I had to pull out the `format_or_verbatim` from the `rome_js_formatter` and move it to `rome_formatter` so that it can be re-used between js and json formatting.
18a71ca to
4b19191
Compare
ematipico
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some prettier tests for JSON5 are failing after implementing array formatting in #4064
The tests fail because the formatting returns a
FormatError::SyntaxErrorif a mandatory child node is missing but the error is never handled by the JSON formatting.This PR fixes this by
format_or_verbatimwhen formatting valuesI had to pull out the
format_or_verbatimfrom therome_js_formatterand move it torome_formatterso that it can be re-used between js and json formatting.Test Plan
I added new tests for an empty file and a file with missing object property values.
Documentation