This repository was archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): useIsNan rule
#4059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
xunilrj
reviewed
Dec 16, 2022
| impl Message { | ||
| fn as_str(&self) -> &str { | ||
| match self { | ||
| Self::BinaryExpression => "Use the isNaN function to compare with NaN.", |
Contributor
There was a problem hiding this comment.
to compare against NaN.
Note: I am not a native speaker. So any native feel free to jump in and confirm this.
Contributor
Author
There was a problem hiding this comment.
I took that one from ESLint. I just checked it on Grammarly, and it didn't complain :P
81d491c to
1257e49
Compare
xunilrj
approved these changes
Dec 16, 2022
leops
approved these changes
Dec 19, 2022
1257e49 to
e693145
Compare
2 tasks
e693145 to
3378822
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3987.
Test Plan
cargo test -p rome_js_analyze -- use_is_nanDocumentation