feat(rome_js_analyze): useMediaCaption rule
#4032
Conversation
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
crates/rome_js_analyze/src/analyzers/nursery/use_media_caption.rs
Outdated
Show resolved
Hide resolved
| <audio {...props} /> | ||
| <video {...props} /> |
There was a problem hiding this comment.
I'm not sure we should match these since props might contains a children property with a track node
There was a problem hiding this comment.
Yeah, I also have mixed feelings about it, but it seems an unlikely scenario.
There was a problem hiding this comment.
Throughout our rules, we decided to not trigger the rules if we have spread props. The main reason is that we don't know the information contained in the object that is being spread.
21ed6ff to
79a9c4b
Compare
ematipico
left a comment
There was a problem hiding this comment.
Use cases that contain {...props} should not trigger the rule. Once fixed these cases, I think we can merge it
08a5d6f to
e2a567c
Compare
e2a567c to
2cf1653
Compare
Summary
Closes #3947.
Test Plan
cargo test -p rome_js_analyze -- use_media_caption