Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyzer): correctly delegate unresolved references to its parent scope #4004

Merged
xunilrj merged 3 commits into from
Dec 7, 2022
Merged

fix(rome_js_analyzer): correctly delegate unresolved references to its parent scope #4004

xunilrj merged 3 commits into from
Dec 7, 2022

Conversation

@xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Dec 7, 2022

Summary

Fixes #4003

Test Plan

> cargo test -p rome_js_analyze -- no_arguments

@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit e881581
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/63908f0c5febc600097764c3

@ematipico ematipico changed the title correctly delegate unresolved references to its parent scope fix(rome_js_analyzer): correctly delegate unresolved references to its parent scope Dec 7, 2022
@xunilrj xunilrj merged commit 388df4e into main Dec 7, 2022
@xunilrj xunilrj deleted the fix/4003-no-arguments branch December 7, 2022 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leops leops Awaiting requested review from leops

1 more reviewer

@ematipico ematipico ematipico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 lint/style/noArguments conditionally misses arguments in a for loop

3 participants

@xunilrj @ematipico