Skip to content

feat: commonjs tree shaking. #5095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jul 1, 2025
Merged

feat: commonjs tree shaking. #5095

merged 33 commits into from
Jul 1, 2025

Conversation

IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Jun 29, 2025 •
edited
Loading

Finish linking and codegen for commonjs tree shaking, adding a testcase

@netlify Netlify
Copy link

netlify bot commented Jun 29, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4887b6f
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68636aeb86befd0008308bd7

@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft June 29, 2025 04:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     91.0±5.37ms        ? ?/sec    1.00     88.8±2.50ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04    100.0±3.91ms        ? ?/sec    1.00     96.6±2.58ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    122.2±4.19ms        ? ?/sec    1.00    122.5±3.28ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    143.3±2.52ms        ? ?/sec    1.00    141.2±2.87ms        ? ?/sec
bundle/bundle@threejs                                        1.05     45.8±2.38ms        ? ?/sec    1.00     43.4±1.26ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     53.9±1.27ms        ? ?/sec    1.00     53.1±0.85ms        ? ?/sec
bundle/bundle@threejs10x                                     1.02   470.5±10.30ms        ? ?/sec    1.00    461.0±8.43ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03   549.7±11.33ms        ? ?/sec    1.00    533.7±9.15ms        ? ?/sec
scan/scan@rome_ts                                            1.03     95.6±2.71ms        ? ?/sec    1.00     92.6±1.71ms        ? ?/sec
scan/scan@threejs                                            1.01     32.8±0.76ms        ? ?/sec    1.00     32.5±1.82ms        ? ?/sec
scan/scan@threejs10x                                         1.00    337.9±5.51ms        ? ?/sec    1.00    338.1±5.82ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY changed the title Feat cjs tree shaking feat: commonjs tree shaking. Jun 30, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review July 1, 2025 04:58
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Jul 1, 2025
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 July 1, 2025 05:12
@IWANABETHATGUY
Copy link
Member Author

Feel free to reply if you found anything not expected, I will fixed it in next pr.

Merged via the queue into main with commit 33a9516 Jul 1, 2025
24 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat-cjs-tree-shaking-2 branch July 1, 2025 05:19
This was referenced Jul 1, 2025
Closed
Merged
hyf0 pushed a commit that referenced this pull request Jul 1, 2025
@github-actions @shulaoda
release: v1.0.0-beta.23 (#5133)
fbab789 
## [1.0.0-beta.23] - 2025-07-01

### 💥 BREAKING CHANGES

- debug: rename debug logs fields to be consitent (#5125) by @antfu

### 🚀 Features

- debug: append `content` for asset data and unify `source` field to
`content`. (#5130) by @hyf0
- debug: emit asset-related data (#5124) by @hyf0
- commonjs tree shaking. (#5095) by @IWANABETHATGUY
- rolldown_plugin_wasm_helper: align behaviors for expected
functionality (#5120) by @shulaoda
- remove `experimental.enableComposingJsPlugins` (#5122) by @shulaoda
- use same option object reference (#5114) by @sapphi-red
- add util function to inspect why the facade symbol is created (#5115)
by @IWANABETHATGUY
- types: expose `ChunkingContext` type (#5112) by @sapphi-red
- scan commonjs exports (#5111) by @IWANABETHATGUY
- debug: remove unneeded source info of render chunk events (#5109) by
@hyf0
- debug: only emit debug information for trace level (#5108) by @hyf0
- debug: emit chunk related informations (#5106) by @hyf0

### 🐛 Bug Fixes

- debug: add hook render chunk start and end events to Meta enum (#5117)
by @hyf0

### 🚜 Refactor

- rust: unify outdated namings (#5127) by @hyf0

### 📚 Documentation

- advanced-chunks: clarify module capturing behavior (#5129) by @hyf0

### 🧪 Testing

- support array output options (#5113) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- remove unused code (#5128) by @IWANABETHATGUY
- remove unnecessary `skipComposingJsPlugin` (#5123) by @shulaoda
- deps: update crate-ci/typos action to v1.34.0 (#5119) by
@renovate[bot]
- deps: update NAPI-RS to 3.0.0-beta.11 (#5110) by @shulaoda

Co-authored-by: shulaoda <[email protected]>
@sapphi-red sapphi-red mentioned this pull request Jul 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shulaoda shulaoda shulaoda approved these changes

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @shulaoda