Skip to content

Conversation

@TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Oct 2, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6130

Description

@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rollup Ready Ready Preview Comment Oct 2, 2025 7:43am

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6130

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-i6idwe3kr-rollup-js.vercel.app/repl/?pr=6133

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Performance report

  • BUILD: 6880ms, 833 MB
    • initialize: 0ms, 25.1 MB
    • generate module graph: 2581ms, 633 MB
      • generate ast: 1371ms, 623 MB
    • sort and bind modules: 390ms, 695 MB
    • mark included statements: 3907ms, 833 MB
      • treeshaking pass 1: 2296ms, 829 MB
      • treeshaking pass 2: 454ms, 843 MB
      • treeshaking pass 3: 390ms, 834 MB
      • treeshaking pass 4: 377ms, 810 MB
      • treeshaking pass 5: 376ms, 833 MB
  • GENERATE: 1055ms (+78ms, +8.0%), 943 MB (+2%)
    • initialize render: 0ms, 952 MB
    • generate chunks: 72ms (-72ms, -50.0%), 973 MB (+4%)
      • optimize chunks: 0ms, 968 MB (+5%)
    • render chunks: 821ms (+168ms, +25.7%), 917 MB (+2%)
    • transform chunks: 18ms, 943 MB (+2%)
    • generate bundle: 0ms, 943 MB (+2%)

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.72%. Comparing base (bef29f4) to head (5ca5dd9).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6133   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         271      271           
  Lines       10637    10638    +1     
  Branches     2846     2847    +1     
=======================================
+ Hits        10501    10502    +1     
  Misses         91       91           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Oct 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2025
@lukastaegert lukastaegert added this pull request to the merge queue Oct 3, 2025
Merged via the queue into master with commit 0fd66e6 Oct 3, 2025
46 checks passed
@lukastaegert lukastaegert deleted the fix/6130 branch October 3, 2025 05:19
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullish coalesce operator wrongly omitted in output

3 participants