Skip to content

feat: optimize in checks on namespaces to keep them treeshake-able #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 27, 2025
Merged

feat: optimize in checks on namespaces to keep them treeshake-able #6029

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5442727
feat: optimize `in` checks on namespaces
cyyynthia Jul 23, 2025
f7370ba
fix: remove bad leftovers
cyyynthia Jul 23, 2025
b233749
fix: set renderedLiteralValue to UnknownValue on deopt for BinaryExpr…
cyyynthia Jul 24, 2025
335b46a
Merge branch 'master' into opt-namespace
lukastaegert Jul 27, 2025
9011da0
Adapt test for changed traceExport signature
lukastaegert Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remove bad leftovers
  • Loading branch information
@cyyynthia
cyyynthia committed Jul 26, 2025
commit f7370ba2fd4add5b97152714d5258ae52bc5460b
16 changes: 8 additions & 8 deletions src/ast/nodes/BinaryExpression.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,12 @@ import {
type LiteralValueOrUnknown,
UnknownValue
} from './shared/Expression';
import { type ExpressionNode, type IncludeChildren, NodeBase } from './shared/Node';
import {
doNotDeoptimize,
type ExpressionNode,
type IncludeChildren,
NodeBase
} from './shared/Node';

type Operator =
| '!='
Expand Down Expand Up @@ -139,13 +144,6 @@ export default class BinaryExpression extends NodeBase implements DeoptimizableE
return type !== INTERACTION_ACCESSED || path.length > 1;
}

applyDeoptimizations(): void {
this.deoptimized = true;
if (this.operator !== 'in' || !this.right.variable?.isNamespace) {
this.scope.context.requestTreeshakingPass();
}
}

include(
context: InclusionContext,
includeChildrenRecursively: IncludeChildren,
Expand Down Expand Up @@ -182,3 +180,5 @@ export default class BinaryExpression extends NodeBase implements DeoptimizableE
}
}
}

BinaryExpression.prototype.applyDeoptimizations = doNotDeoptimize;