Remove Font Awesome #1809
Merged
Remove Font Awesome #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What would be nice is good documentation on how to add it again. This and the default grid (removed in Beta 2) provided really good examples to work from especially considering that 1) "how do I add FontAwesome" is a REALLY frequent question on Discourse, and 2) Bootstrap 4 doesn't (yet?) effectively document how to use So I frequently reference These examples could be easily maintained on a page on the website, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
font awesome was added in sage 9 mainly to provide a good example out of the box on how to add a 3rd party package
there's a few issues:
this will instead be moved to the docs