Fixes that were introduced when moving batch to webdav_api (read only after the batch succeeded) #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the mirage-kv implementation of git/irmin does follow the mirage-kv interface, and reads on the kv-store while processing the batch are reading the old state (which in this case is non-existing). unfortunately, mirage-kv-mem (and mirage-kv-unix) behave differently in the batch operation, and this cannot be tested easily.
edits of the prop file (due to batch, the get_property_map will be wrong)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 28, 2022
CHANGES: * unikernel: upgrade to mirage 4.3 (robur-coop/caldav#31 @hannesm) * bugfix: href_to_principal always returned "/principals" (since v0.1.1) (robur-coop/caldav#24 @hannesm) * error when principal or calendar already exists when adding a new principal (robur-coop/caldav#24 @hannesm) * when modifying an ACL, check that all referenced principals exist (robur-coop/caldav#24 @hannesm) * check for groups and principals on operations thereof (i.e. disallow deleting a group when the principal is a user, etc.) and test cases (robur-coop/caldav#25 @hannesm) * use batch in Webdav_api instead of Webdav_fs to reduce commits (robur-coop/caldav#26, fixes in robur-coop/caldav#27 @hannesm) * bugfix: adding and removing groups and users, only edit prop file once (robur-coop/caldav#27 @hannesm) * bugfix: compute etag after batch (robur-coop/caldav#27 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.