adding check-nws-nwc-xml folder #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
requested changes
May 23, 2022
Member
There was a problem hiding this comment.
Hi @davidetome
Great work!
I've got a couple of comments though:
- I would avoid calling the folder
check-nws-nwc-xmlas this is just a first usage. You may consider inserting an intermediate folder level. Something likeexperimentalSetups/check-xml/nws-nwc/. - Once done, I would like you to provide a README.md in the first level (i.e.,
check-xml) documenting the general principles and how it was important for the CAN robots which lack the standarddry-runoption. - All the rest may go within the second level (i.e.,
nws-nwc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
experimentalSetups/check-nws-nwc-xmlfolder containing the code used to check theXMLfiles consistency after manual modification due to the newNWS/NWClayers implemented inYARP-3.5.cc @randaz81 @triccyx