iCubTemplateV6 #345
Merged
iCubTemplateV6 #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
reviewed
Mar 15, 2022
Member
|
Hi @valegagge Could you please review the PR? |
Contributor
Author
|
just spoke w/ @valegagge , fixed the template as decided, we'll go on w/ the wiki mods |
Member
|
Perfect! |
Contributor
Author
|
Ciao @valegagge. please take a look at the diagrams |
Member
Great! We checked the diagrams together. |
Member
|
After a chat with @ale-git, I updated the motor control config file accordinglyhere. |
Updated body_part--ebX-jA_B-mc.xml of mc version 6
pattacini
approved these changes
Mar 19, 2022
Member
pattacini
left a comment
There was a problem hiding this comment.
Thanks heaps @davidetome and @valegagge for this contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to discuss changes in order to document the migration to motor control v6.
@valegagge the
body_part--ebX-jA_B-mc.xmlwas already aligned to body_part--ebX-jA_B-mc.xml.txt a part of some comments added in the first commit.I just added the groups for each board described in Tutorial.txt
cc @pattacini @ale-git