Skip to content

Conversation

@SanLordKevin
Copy link
Contributor

Adding the configuration files for the neck mk3 bench setup.
There are also two files for some automatic movement using the yarpmotogui.

@SanLordKevin
Copy link
Contributor Author

I added a short readme and one photo in the assets.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Just a few inline suggestions that you can commit straight away from the PR GUI (by just clicking on the button commit suggestion)

@SanLordKevin
Copy link
Contributor Author

Done, thanks for the suggestions!

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me!
Awaiting the PR in ready for review.

@SanLordKevin SanLordKevin marked this pull request as ready for review November 20, 2024 10:18
@pattacini
Copy link
Member

I think I can safely merge the PR.
Possible refinements can be applied at a later stage, @marcoaccame @valegagge

@pattacini pattacini merged commit de271a5 into robotology:devel Nov 20, 2024
@SanLordKevin SanLordKevin deleted the neck_2joints branch November 20, 2024 10:24
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SanLordKevin ,
it seems fine to me.

I don't know if you already did, but to test if your configuration doesn't contain typos or some parameters are missing I suggest running yarprobotinterface with the parameter

 <group name="DEBUG">
        <param name="embBoardsConnected"> 0 </param>
</group>

in the general.xml file. In this way, yarprobotinterface starts and parsers all the files without checking the connected board.

Obviously, the correctness of the value of each parameter will be done using the real setup.

@pattacini
Copy link
Member

pattacini commented Nov 20, 2024

Obviously, the correctness of the value of each parameter will be done using the real setup.

Already tested ✅
Nice suggestion anyway 👍🏻

@SanLordKevin
Copy link
Contributor Author

I don't know if you already did, but to test if your configuration doesn't contain typos or some parameters are missing I suggest running yarprobotinterface with the parameter

 <group name="DEBUG">
        <param name="embBoardsConnected"> 0 </param>
</group>

in the general.xml file. In this way, yarprobotinterface starts and parsers all the files without checking the connected board.

Thanks! I didn't knew that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants