-
Couldn't load subscription status.
- Fork 74
neckmk3_2joints experimental setup #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I added a short readme and one photo in the assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Just a few inline suggestions that you can commit straight away from the PR GUI (by just clicking on the button commit suggestion)
Co-authored-by: Ugo Pattacini <[email protected]>
Co-authored-by: Ugo Pattacini <[email protected]>
Co-authored-by: Ugo Pattacini <[email protected]>
|
Done, thanks for the suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me!
Awaiting the PR in ready for review.
|
I think I can safely merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SanLordKevin ,
it seems fine to me.
I don't know if you already did, but to test if your configuration doesn't contain typos or some parameters are missing I suggest running yarprobotinterface with the parameter
<group name="DEBUG">
<param name="embBoardsConnected"> 0 </param>
</group>
in the general.xml file. In this way, yarprobotinterface starts and parsers all the files without checking the connected board.
Obviously, the correctness of the value of each parameter will be done using the real setup.
Already tested ✅ |
Thanks! I didn't knew that! |
Adding the configuration files for the neck mk3 bench setup.
There are also two files for some automatic movement using the
yarpmotogui.