Fixing Jenkins' Flake8 regressions #1626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mirko Arena <[email protected]>
Member
Author
|
Add about building: http://192.195.81.208:22082/job/build-rockstor-core/31/console Yesterday had same issue while building share usage commits, had to bootstrap.py and rebuild M. |
Member
Author
|
@schakrava & @phillxnet : After fetching PR on jenkins, instead of flake8 full Rockstor env we can check it against modified .py files:
git diff --name-only always returns Mirko |
Member
|
Thanks @MFlyer, nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins' Flake8 doesn't like some files, so we fix them
Ready to be merged @schakrava
Can we have it running against PR diffs instead of all Rockstor repo structure? This can speed up flake8 task :)
Mirko