feat(zql): scaffolding for ivm-2
#2109
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was trying to figure out the best way to go about updating the IVM code given the core types flowing through it are changing. Rather than update the code and have to track down a million type errors and try to change everything all at once it strikes me as being easier to create an
ivm-2
directory and re-implement (potentially using copy-pasta from the ivm dir) the operators, sources and views.Once
ivm-2
is done we can swap it into the rest of the machinery (ast, query builder, pipeline builder) and delete the oldivm
directory.This PR lays out the scaffolding for IVM and re-introduces (while also fixing, streamlining and renaming):
The PR also implements the
NestedIterable
.NestedIterable
has been renamed toIterableTree
here. I thinkIterableTree
is a more accurate of a description since sibling iterables can exist.Now that we have the scaffolding and
IterableTree
, plugging in the operators should be relatively straightforward.Next steps:
pull