AuthDO schema migration refinements #515
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| storage, | ||
| lc, | ||
| storageSchemaMeta, | ||
| STORAGE_SCHEMA_VERSION, |
There was a problem hiding this comment.
Okay, I see now.
In that case, I think it would be safer to specify the actual version number in these calls (i.e. 1 instead of STORAGE_SCHEMA_VERSION), so that when subsequent migration steps steps are added, the previous steps don't need to be changed.
Then we would add a check in migrate...() that the version <= STORAGE_SCHEMA_VERSION.
wdyt?
There was a problem hiding this comment.
Great suggestion. Done.
a92bf77 to
71c4c6b
Compare
| this._initRoutes(); | ||
| this._lc.info?.('Starting server'); | ||
| this._lc.info?.('Version:', version); | ||
| void state.blockConcurrencyWhile(() => |
There was a problem hiding this comment.
.catch would be better and log the error if any.
| minSafeRollbackVersion: number; | ||
| }; | ||
|
|
||
| async function migrateStorageSchemaToVersion( |
There was a problem hiding this comment.
Does it make sense to move this to another file? This file is getting large.
| (await storage.get(AUTH_DO_STORAGE_SCHEMA_VERSION_KEY)) ?? 0; | ||
| if (storageSchemaVersion >= AUTH_DO_STORAGE_SCHEMA_VERSION) { | ||
| return; | ||
| lc.addContext('SchemaUpdate'); |
| storage, | ||
| CONNECTION_KEY_PREFIX, | ||
| )) { | ||
| await storage.delete(connectionKeyString); |
There was a problem hiding this comment.
Would it be worth using multi delete here and below?
Update AuthDO schema migration logic to deal with down-migrates (i.e. dealing with rolling back a deploy that does a migration).
Also address arv's feedback from #491