Skip to content

Conversation

arv
Copy link
Contributor

@arv arv commented Oct 9, 2025

Reverts #4979

This is a revert of the revert

Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
replicache-docs Ready Ready Preview Comment Oct 9, 2025 7:12am
zbugs Ready Ready Preview Comment Oct 9, 2025 7:12am

Copy link

github-actions bot commented Oct 9, 2025

🐰 Bencher Report

Branchrevert-4979-revert-4975-arv/inspector-read-rows
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
zpg: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
988.42 ops/s
(-2.83%)Baseline: 1,017.16 ops/s
872.02 ops/s
(88.22%)
zpg: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
1,051.56 ops/s
(-1.05%)Baseline: 1,062.71 ops/s
963.39 ops/s
(91.62%)
zpg: (table scan) select * from album📈 view plot
🚷 view threshold
716.92 ops/s
(-0.42%)Baseline: 719.92 ops/s
617.88 ops/s
(86.18%)
zpg: OR with empty branch and limit📈 view plot
🚷 view threshold
955.28 ops/s
(+2.57%)Baseline: 931.38 ops/s
848.67 ops/s
(88.84%)
zpg: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
786.51 ops/s
(+0.98%)Baseline: 778.85 ops/s
737.70 ops/s
(93.79%)
zpg: all playlists📈 view plot
🚷 view threshold
5.56 ops/s
(-0.06%)Baseline: 5.56 ops/s
5.34 ops/s
(96.10%)
zpg: scan with one depth related📈 view plot
🚷 view threshold
422.80 ops/s
(-1.78%)Baseline: 430.48 ops/s
407.99 ops/s
(96.50%)
zql: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
130,058.53 ops/s
(+5.88%)Baseline: 122,834.45 ops/s
105,797.24 ops/s
(81.35%)
zql: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
2,223.35 ops/s
(+3.08%)Baseline: 2,156.97 ops/s
2,001.11 ops/s
(90.00%)
zql: (table scan) select * from album📈 view plot
🚷 view threshold
6,527.78 ops/s
(-2.36%)Baseline: 6,685.67 ops/s
6,264.94 ops/s
(95.97%)
zql: OR with empty branch and limit📈 view plot
🚷 view threshold
58,211.59 ops/s
(+1.76%)Baseline: 57,207.26 ops/s
46,504.57 ops/s
(79.89%)
zql: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
11,956.76 ops/s
(-4.22%)Baseline: 12,483.99 ops/s
11,520.23 ops/s
(96.35%)
zql: all playlists📈 view plot
🚷 view threshold
4.45 ops/s
(+4.01%)Baseline: 4.28 ops/s
4.01 ops/s
(90.08%)
zql: edit for limited query, inside the bound📈 view plot
🚷 view threshold
222,715.60 ops/s
(+1.39%)Baseline: 219,659.37 ops/s
210,374.79 ops/s
(94.46%)
zql: edit for limited query, outside the bound📈 view plot
🚷 view threshold
215,227.39 ops/s
(-0.36%)Baseline: 215,999.05 ops/s
188,188.87 ops/s
(87.44%)
zql: push into limited query, inside the bound📈 view plot
🚷 view threshold
111,383.95 ops/s
(+0.56%)Baseline: 110,764.12 ops/s
106,567.74 ops/s
(95.68%)
zql: push into limited query, outside the bound📈 view plot
🚷 view threshold
413,756.99 ops/s
(-3.34%)Baseline: 428,043.77 ops/s
393,189.08 ops/s
(95.03%)
zql: push into unlimited query📈 view plot
🚷 view threshold
345,732.34 ops/s
(+1.45%)Baseline: 340,787.55 ops/s
313,701.38 ops/s
(90.74%)
zql: scan with one depth related📈 view plot
🚷 view threshold
500.25 ops/s
(+4.86%)Baseline: 477.04 ops/s
433.60 ops/s
(86.68%)
zqlite: (pk lookup) select * from track where id = 3163📈 view plot
🚷 view threshold
42,812.85 ops/s
(-0.84%)Baseline: 43,174.07 ops/s
40,551.31 ops/s
(94.72%)
zqlite: (secondary index lookup) select * from track where album_id = 248📈 view plot
🚷 view threshold
10,165.31 ops/s
(-0.28%)Baseline: 10,193.62 ops/s
9,730.55 ops/s
(95.72%)
zqlite: (table scan) select * from album📈 view plot
🚷 view threshold
1,312.31 ops/s
(-2.38%)Baseline: 1,344.31 ops/s
1,247.96 ops/s
(95.10%)
zqlite: OR with empty branch and limit📈 view plot
🚷 view threshold
18,432.07 ops/s
(+2.03%)Baseline: 18,064.67 ops/s
17,403.10 ops/s
(94.42%)
zqlite: OR with empty branch and limit with exists📈 view plot
🚷 view threshold
5,811.52 ops/s
(+4.58%)Baseline: 5,556.81 ops/s
5,287.58 ops/s
(90.98%)
zqlite: all playlists📈 view plot
🚷 view threshold
1.41 ops/s
(+0.27%)Baseline: 1.41 ops/s
1.33 ops/s
(94.39%)
zqlite: edit for limited query, inside the bound📈 view plot
🚷 view threshold
118,302.11 ops/s
(+0.81%)Baseline: 117,349.59 ops/s
111,843.12 ops/s
(94.54%)
zqlite: edit for limited query, outside the bound📈 view plot
🚷 view threshold
118,970.72 ops/s
(-0.28%)Baseline: 119,309.80 ops/s
113,696.10 ops/s
(95.57%)
zqlite: push into limited query, inside the bound📈 view plot
🚷 view threshold
3,890.63 ops/s
(+0.48%)Baseline: 3,872.00 ops/s
3,737.66 ops/s
(96.07%)
zqlite: push into limited query, outside the bound📈 view plot
🚷 view threshold
149,382.96 ops/s
(+2.64%)Baseline: 145,541.55 ops/s
137,091.03 ops/s
(91.77%)
zqlite: push into unlimited query📈 view plot
🚷 view threshold
133,928.76 ops/s
(+6.34%)Baseline: 125,944.61 ops/s
113,624.40 ops/s
(84.84%)
zqlite: scan with one depth related📈 view plot
🚷 view threshold
164.55 ops/s
(+0.15%)Baseline: 164.30 ops/s
153.44 ops/s
(93.25%)
🐰 View full continuous benchmarking report in Bencher

Copy link

github-actions bot commented Oct 9, 2025

🐰 Bencher Report

Branchrevert-4979-revert-4975-arv/inspector-read-rows
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,367.36 KB
(+0.03%)Baseline: 1,366.90 KB
1,394.24 KB
(98.07%)
zero.js📈 view plot
🚷 view threshold
225.61 KB
(+0.02%)Baseline: 225.57 KB
230.08 KB
(98.06%)
zero.js.br📈 view plot
🚷 view threshold
63.11 KB
(+0.08%)Baseline: 63.06 KB
64.32 KB
(98.12%)
🐰 View full continuous benchmarking report in Bencher

Copy link

github-actions bot commented Oct 9, 2025

🐰 Bencher Report

Branchrevert-4979-revert-4975-arv/inspector-read-rows
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
src/client/custom.bench.ts > big schema📈 view plot
🚷 view threshold
887.91 ops/s x 1e3
(+7.53%)Baseline: 825.75 ops/s x 1e3
657.19 ops/s x 1e3
(74.02%)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
2.92 ops/s x 1e3
(+3.57%)Baseline: 2.82 ops/s x 1e3
2.67 ops/s x 1e3
(91.61%)
src/client/zero.bench.ts > pk compare > pk = N📈 view plot
🚷 view threshold
43.72 ops/s x 1e3
(+0.23%)Baseline: 43.62 ops/s x 1e3
41.86 ops/s x 1e3
(95.74%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
4.08 ops/s x 1e3
(-1.85%)Baseline: 4.15 ops/s x 1e3
3.97 ops/s x 1e3
(97.45%)
🐰 View full continuous benchmarking report in Bencher

@arv arv added this pull request to the merge queue Oct 9, 2025
Copy link

github-actions bot commented Oct 9, 2025

🐰 Bencher Report

Branchrevert-4979-revert-4975-arv/inspector-read-rows
Testbedself-hosted
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
src/size-of-value.bench.ts > getSizeOfValue performance > arrays > large array (100 items)📈 view plot
🚷 view threshold
1,706.88 ops/s x 1e3
(+0.07%)Baseline: 1,705.76 ops/s x 1e3
1,656.40 ops/s x 1e3
(97.04%)
src/size-of-value.bench.ts > getSizeOfValue performance > arrays > small array (10 items)📈 view plot
🚷 view threshold
5,476.98 ops/s x 1e3
(-0.32%)Baseline: 5,494.51 ops/s x 1e3
5,293.03 ops/s x 1e3
(96.64%)
src/size-of-value.bench.ts > getSizeOfValue performance > datasets > large dataset (100x512B)📈 view plot
🚷 view threshold
67.76 ops/s x 1e3
(-12.06%)Baseline: 77.05 ops/s x 1e3
60.97 ops/s x 1e3
(89.98%)
src/size-of-value.bench.ts > getSizeOfValue performance > datasets > small dataset (10x256B)📈 view plot
🚷 view threshold
600.16 ops/s x 1e3
(-12.27%)Baseline: 684.08 ops/s x 1e3
551.14 ops/s x 1e3
(91.83%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > nested object📈 view plot
🚷 view threshold
2,993.40 ops/s x 1e3
(-7.50%)Baseline: 3,236.22 ops/s x 1e3
2,857.07 ops/s x 1e3
(95.45%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (1KB)📈 view plot
🚷 view threshold
3,462.17 ops/s x 1e3
(-9.35%)Baseline: 3,819.07 ops/s x 1e3
3,192.30 ops/s x 1e3
(92.21%)
src/size-of-value.bench.ts > getSizeOfValue performance > objects > structured object (256B)📈 view plot
🚷 view threshold
3,488.88 ops/s x 1e3
(-8.54%)Baseline: 3,814.78 ops/s x 1e3
3,233.16 ops/s x 1e3
(92.67%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > boolean📈 view plot
🚷 view threshold
7,793.08 ops/s x 1e3
(+2.81%)Baseline: 7,579.81 ops/s x 1e3
7,184.36 ops/s x 1e3
(92.19%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > integer📈 view plot
🚷 view threshold
7,769.51 ops/s x 1e3
(+2.17%)Baseline: 7,604.56 ops/s x 1e3
7,221.78 ops/s x 1e3
(92.95%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > null📈 view plot
🚷 view threshold
7,757.50 ops/s x 1e3
(+1.49%)Baseline: 7,643.28 ops/s x 1e3
7,192.76 ops/s x 1e3
(92.72%)
src/size-of-value.bench.ts > getSizeOfValue performance > primitives > string (100 chars)📈 view plot
🚷 view threshold
1,136.02 ops/s x 1e3
(+0.72%)Baseline: 1,127.86 ops/s x 1e3
1,073.58 ops/s x 1e3
(94.50%)
🐰 View full continuous benchmarking report in Bencher

Merged via the queue into main with commit 8773379 Oct 9, 2025
14 checks passed
@arv arv deleted the revert-4979-revert-4975-arv/inspector-read-rows branch October 9, 2025 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant