This repository was archived by the owner on Feb 24, 2020. It is now read-only.
stage1/fly: Add a working enter implementation #3377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a working `rkt enter` implementation for the fly stage1. It just chroots into the pod's rootfs and execs its arguments. Fixes #2957
Contributor
|
A few small suggestions, but looks great! |
lucab
approved these changes
Nov 18, 2016
Member
lucab
left a comment
There was a problem hiding this comment.
Two notes for possible followups, but per-se this LGTM.
| func execArgs() error { | ||
| argv0 := flag.Arg(0) | ||
| argv := flag.Args() | ||
| envv := []string{} |
Member
There was a problem hiding this comment.
Note to self: fly should write env var in a stage1 file (under /rkt/env/) and here we should set them back and ensuring that there is a sane $TERM set.
| if err := syscall.Chroot(root); err != nil { | ||
| log.FatalE("Failed to chroot", err) | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Note to self: we should have uid/gid/supp-gid for the original application at this point and set them back here.
This was referenced Nov 21, 2016
Quentin-M
added a commit
to Quentin-M/stackanetes
that referenced
this pull request
Dec 5, 2016
Kubernetes relies on `rkt enter` to execute lifecycle hooks, however before rkt 1.20, this command is not available with rkt stage1-fly, which is used in nova-libvirt. See rkt/rkt#3377
Quentin-M
added a commit
to Quentin-M/stackanetes
that referenced
this pull request
Dec 6, 2016
Kubernetes relies on `rkt enter` to execute lifecycle hooks, however before rkt 1.20, this command is not available with rkt stage1-fly, which is used in nova-libvirt. See rkt/rkt#3377
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a working
rkt enterimplementation for the fly stage1. It justchroots into the pod's rootfs and execs its arguments.
Fixes #2957